-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): arm64 tests — pass binding selector to container; build node with explicit target #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jgowdy-godaddy
wants to merge
33
commits into
main
Choose a base branch
from
fix/arm64-tests-20251002140047
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+198
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with explicit target
…ent; node addon path; python uses maturin develop
…rtifact download in tests-arm64
…TH; ignore missing python artifact in assemble; improve node addon error detail
…RARY_PATH and build Java JNI
…nterop; verbose pytest
…braryPath for JNI load
…for loader compatibility
… path to stabilize Fiddle load
…latform tag conflict
Maturin in manylinux container was detecting multiple platform tags due to inherited workspace cache paths. Clear these env vars so maturin uses its own isolated environment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The maturin-action was still detecting multiple platform tags because cached cargo artifacts from other builds were present. Remove these caches before Python builds to ensure clean manylinux environment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Unset all workspace cache environment variables when running maturin-action to prevent the Docker container from inheriting paths that cause platform tag conflicts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Maturin may be detecting platform tags from leftover output artifacts. Clean the output directory and recreate it before building. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace maturin-action with direct docker run commands to avoid environment variable inheritance issues that cause platform tag conflicts. This gives us complete control over the build environment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The manylinux containers have Python in /opt/python/cpXX-cpXX/bin, not in the standard PATH. Use the cp38-cp38 interpreter directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.