This repository was archived by the owner on Jun 3, 2026. It is now read-only.
Ensure integration test failures fail the CI build#146
Merged
Conversation
Add set -euo pipefail and explicit exit-on-failure guards to all test commands in integration-test.sh. Prevents silent test failures from producing a green CI build (fixes #120).
Use ${GOROOT:-} default to handle GOROOT not being set, which is the
case when actions/setup-go already puts go on PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -euo pipefailtointegration-test.sh(was justset -e)|| { echo "FAIL: ..."; exit 1; }guards on all four test commands (go testencrypt/decrypt,cucumber-jsencrypt/decrypt)This ensures that if any integration test fails in the future, the CI build fails with a clear error message rather than silently succeeding. Addresses the concern raised in #120.
Test plan