fix(domain): show renewal price consistently across available/quote/suggest (GDDEVPLAT-133)#125
Merged
Merged
Conversation
…uggest (GDDEVPLAT-133) `domain available` and `domain quote` already computed `renewalPrice` (and `available` also computed `period`) but omitted them from the default table view, unlike `domain suggest`. Add them to each command's default fields so the human view matches what's already in `--output json`, and fill in the resolved domain in the `domain quote`/`domain suggest` next-action suggestions so they're copy/paste-ready instead of showing the raw `<domain>`/`<query>` placeholder. Also bump cli-engine to 0.4.6, which makes `--fields`/`default_fields` order drive both display order and column hide-priority for commands without a custom human view. Set `auth scopes`'s default fields explicitly so `scope` isn't pushed out of view by wider columns.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the human-default table views for domain commands with their existing JSON output by surfacing renewalPrice (and period for availability), improves next-action suggestions by pre-filling resolved domain/query parameters, and updates cli-engine to 0.4.6 (with an explicit default field order for auth scopes to preserve visibility under the new ordering behavior).
Changes:
- Add
renewalPrice(andperiodwhere applicable) todefault_fieldsfordomain availableanddomain quote, plus regression tests. - Pre-fill
domain quote/domain suggestnext-action parameters using the resolved domain value. - Bump
cli-engineto0.4.6and explicitly setauth scopesdefault field order.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/src/scopes_cmd.rs | Sets explicit default_fields ordering for auth scopes to keep key columns visible. |
| rust/src/domain/quote.rs | Adds renewalPrice to default fields; pre-fills suggest next-action query; adds regression test. |
| rust/src/domain/available.rs | Adds renewalPrice/period to default fields; pre-fills next-action params; adds regression test. |
| rust/Cargo.toml | Bumps cli-engine dependency to 0.4.6. |
| rust/Cargo.lock | Updates lockfile for cli-engine 0.4.6. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d match
Copilot review feedback: fields.contains("renewalPrice") would also
match a future field like renewalPrice1Year. Split on "," and compare
each field exactly instead.
qcai-godaddy
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domain availableanddomain quotealready computedrenewalPrice(andavailablealso computedperiod) via the sameSimpleMoney/TermPricetypes andcommon.rshelpers used bydomain suggest, but omitted them from the default table view. Add them to each command'sdefault_fieldsso the human view matches--output json, closing GDDEVPLAT-133.domain available/domain quotenext-action suggestions (domain quote <domain>,domain suggest <query>) so they render as copy/paste-ready commands instead of the raw placeholder.cli-engineto 0.4.6, which makes--fields/default_fieldsorder drive both display order and column hide-priority for commands without a custom human view.auth scopes'sdefault_fieldsexplicitly (scope,description,commands,default) soscopeisn't pushed out of view by wider columns under the new ordering behavior.Test plan
cargo build/cargo clippy --all-targets -- -D warnings/cargo fmt --check(fromrust/)cargo test --all-targets— 269 passeddomain available,domain quote,domain suggestagainst the test environment with--humanand--json, confirmingrenewalPrice/periodnow show by default and next-action commands are filled in with the resolved domain