-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of android readme #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! This is a very helpful introductory guide to Android! 🙂
Several formatting issues -- I mentioned them in some comments, but make sure they are applied to the whole page. Examples:
- Proper capitalization of names like "Godot", "Linux" or "Android" and abbreviations like "CLI" and "NDK".
- No double spaces between sentences, ever.
- Single instead of double backticks for monospace.
Also check that CI passes, it already fixes some of those issues.
@TCROC it's been a month, any update/response to my comments? 🙂 |
@Bromeon I agree them! :) I just have to get around to updating the PR with them. Probably going to once I get ios and mac working properly on this next part in my game. Which will also include PRs to the book for ios and mac support :) |
ea255fc
to
9d45c48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
dce08f5
to
5f59a17
Compare
I believe I fixed all suggestions! :) Let me know if you find anything else! :) |
f1439be
to
18adb72
Compare
Suggestions have been applied :) Ready for further review :) |
Thank you very much for all the improvements! 😊 |
Absolutely! Glad to get additional platforms officially into the docs! :) |
This is just a first draft for Android. Please critique it and let me know what changes you want made. Android definitely has quite a few steps to it, but good news is: IT WORKS! :)