Skip to content

Conversation

PizzaLovers007
Copy link
Contributor

@PizzaLovers007 PizzaLovers007 commented Apr 24, 2025

Note: This PR is superseded by #1210.


This was the demo used to showcase the implementation of DSP time and play_scheduled() from godotengine/godot#105510.

Things to try:

  • Swap between play and play_scheduled for the metronome ticks.
  • Adjust max FPS to showcase the effect on the metronome.

The metronome sound was recorded by Ludwig Peter Müller in December 2020 under the "Creative Commons CC0 1.0 Universal" license, and all other assets were made by me.

(At the time of writing this, the play_scheduled() PR isn't merged yet, so this project shouldn't be merged until then.)

@PizzaLovers007
Copy link
Contributor Author

Quick question on the web export: is threads enabled? The demo needs threads since it's controlling max FPS, and play_scheduled only supports streams. Without threads the sounds gets really crunchy 😅

@fire
Copy link
Member

fire commented Apr 24, 2025

@adamscott I forget, do you know?

@fire
Copy link
Member

fire commented Apr 25, 2025

I would recommend defaulting to like 10 fps so the changes are obvious.

@PizzaLovers007
Copy link
Contributor Author

I would recommend defaulting to like 10 fps so the changes are obvious.

Sure thing, changed it to 10.

@Calinou
Copy link
Member

Calinou commented Apr 25, 2025

Quick question on the web export: is threads enabled? The demo needs threads since it's controlling max FPS, and play_scheduled only supports streams. Without threads the sounds gets really crunchy 😅

Threads are enabled on CI: https://github.com/godotengine/godot-demo-projects/blob/master/.github/dist/export_presets.cfg#L24

PizzaLovers007 added a commit to PizzaLovers007/godot-demo-projects that referenced this pull request May 1, 2025
Compared to godotengine#1199, this includes a "Song Beat Count" that dynamically changes the loop, which utilizes scheduled_end_time in AudioStreamPlaybackScheduled.
PizzaLovers007 added a commit to PizzaLovers007/godot-demo-projects that referenced this pull request May 2, 2025
Compared to godotengine#1199, this includes a "Song Beat Count" that dynamically changes the loop, which utilizes scheduled_end_time in AudioStreamPlaybackScheduled.
PizzaLovers007 added a commit to PizzaLovers007/godot-demo-projects that referenced this pull request May 6, 2025
Compared to godotengine#1199, this includes a "Song Beat Count" that dynamically changes the loop, which utilizes scheduled_end_time in AudioStreamPlaybackScheduled.
PizzaLovers007 added a commit to PizzaLovers007/godot-demo-projects that referenced this pull request Jun 6, 2025
Compared to godotengine#1199, this includes a "Song Beat Count" that dynamically changes the loop, which utilizes scheduled_end_time in AudioStreamPlaybackScheduled.
PizzaLovers007 added a commit to PizzaLovers007/godot-demo-projects that referenced this pull request Jun 6, 2025
Compared to godotengine#1199, this includes a "Song Beat Count" that dynamically changes the loop, which utilizes scheduled_end_time in AudioStreamPlaybackScheduled.
@PizzaLovers007
Copy link
Contributor Author

Closing this one in favor of #1210.

PizzaLovers007 added a commit to PizzaLovers007/godot-demo-projects that referenced this pull request Jun 6, 2025
Compared to godotengine#1199, this includes a "Song Beat Count" that dynamically changes the loop, which utilizes scheduled_end_time in AudioStreamPlaybackScheduled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants