Fixed an issue with WebRTC signaling example server parsing #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umbers are always parsed as a float, so checks have been added for both equality (x=int(x)) and type equality (typeof(x) = TYPE_FLOAT), for both the message ID and type.\n This means the demo will run correctly, as previously the server could be started from the UI, but not joined, at least via a desktop environment with webrtc Gdextension.
Calinou
reviewed
Jun 30, 2025
Comment on lines
+210
to
+212
| if not typeof(parsed.type) == TYPE_FLOAT and int(parsed.type) == parsed.type: | ||
| return false | ||
| if not typeof(parsed.id == TYPE_FLOAT) and int(parsed.id) == parsed.id: |
There was a problem hiding this comment.
The parentheses for typeof() don't end at the same position in both checks, is that intended?
There was a problem hiding this comment.
This would check the type of bool, and then check if that is 0 or not, that doesn't seem right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went to try out the WebRTC Signaling example - hit Listen, and then connect, and got an error.
I then tried the included node server, which worked perfectly.
After adding some debugging prints, I found an issue within _parse_msg - JSON numbers are always parsed as a float, and so this code:
fails, as these are both floats (and not valid ints).
Checks have been adjusted for both equality (x=int(x)) and type equality (typeof(x) = TYPE_FLOAT), for both the message ID and type.
This means the demo will run correctly, as previously the server could be started from the UI, but not joined, at least via a desktop environment with webrtc Gdextension.