Document shadowmasks in Using LightmapGI #10482
Merged
+79
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Calinou
commented
Jan 7, 2025
Calinou
commented
- See Implement LightmapGI shadowmasks godot#85653.
9 tasks
Calinou
added
enhancement
area:manual
Calinou
force-pushed
the
using-lightmap-gi-shadowmask
branch
from
eee6b23 to
28a7a0b
Compare
|
Not a native English speaker, but it seems "good enough" for me ^-^ |
tetrapod00
approved these changes
Jan 7, 2025
Contributor
tetrapod00
left a comment
tetrapod00
left a comment
There was a problem hiding this comment.
Looks good and I trust Calinou on the technical details.
This looks like 4.4 only but let me know if I missed some discussion of cherrypicking in the original PR?
Member
Author
Yes, it's 4.4-only. |
mhilbrunner
approved these changes
Jan 8, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.