Skip to content

Conversation

@skyace65
Copy link
Contributor

Does what the title says. Images have been updated, and information on the Frame Synthesis and Spatial Entity extensions have been added. Descriptions are basically taken word for word from the PRs that added them.

Frame Synthesis PR: godotengine/godot#109803
Spatial Entities PR: godotengine/godot#107391

@skyace65 skyace65 added this to the 4.6 milestone Dec 19, 2025
@skyace65 skyace65 added enhancement topic:xr Related to XR documentation area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Dec 19, 2025
Comment on lines 293 to 294
Spatial Entity
~~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Spatial Entity
~~~~~~~~~~~~~~
Spatial Entities
~~~~~~~~~~~~~~~~

How it's usually called

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it's named on the settings page, I'd rather keep them consistent.
image

Copy link
Member

@AThousandShips AThousandShips Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's inconsistent with other places, the documentation uses "spatial entities", the settings also says "render model" but the entry here and the associated page says "render models", it's weird to me that the section "Spatial Entity" links to the page "spatial entities", also the OpenXR extension name is "spatial entities" not "spatial entity"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BastiaanOlij is the actual name of the extension the plural version or the singluar version? Because the Kronos website blog uses plural, but then the spec sheet uses singular (here)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard one, because we can make arguments for both which is why in this case we see both, even in OpenXRs official documentation.

When we look at a given extension, it's generally named singular. So XR_EXT_spatial_entity, XR_EXT_render_model, XR_EXT_dpad_binding, etc. even though each manages a multitude of objects or items.

However when we look at spatial entities it isn't just the one extension that defines what a single spatial entity looks like. It's a collection of extensions that further detail out how to access different types of spatial entities.
As a system, plural makes more sense imho.

@skyace65
Copy link
Contributor Author

Made suggested changes except for the Spatial Entity subsection name change.

Spatial Entity
~~~~~~~~~~~~~~

This extension and its settings are used to obtain and interacting with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This extension and its settings are used to obtain and interacting with
This extension and its settings are used to obtain and interact with

@BastiaanOlij
Copy link
Contributor

bar the discussion around singular/plural, great to see the docs being updated to include recent additions! thanks!

@skyace65
Copy link
Contributor Author

Fixed. The section name is now using "Entities"

@mhilbrunner mhilbrunner merged commit 961ed23 into godotengine:master Jan 10, 2026
1 check passed
@mhilbrunner
Copy link
Member

Thank you!

@skyace65 skyace65 deleted the XRSettings branch January 10, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:xr Related to XR documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants