Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation Tree Editor Crashes. #102374

Closed
eddieataberk opened this issue Feb 3, 2025 · 6 comments · Fixed by #102432
Closed

Animation Tree Editor Crashes. #102374

eddieataberk opened this issue Feb 3, 2025 · 6 comments · Fixed by #102432
Labels
bug crash regression topic:animation topic:editor
Milestone
4.4

Comments

@eddieataberk
Copy link

Tested versions

Reproducible in every commit after 96a6dc2

System information

Godot v4.4.beta unknown - Windows 11 (build 22631) - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4080 Laptop GPU (NVIDIA; 32.0.15.6636) - Intel(R) Core(TM) i9-14900HX (32 threads)

Issue description

after following commit Animation Tree works fine in game but switching to the Animation Tree Editor in the bottom panel crashes the editor.
96a6dc2

Image

Steps to reproduce

Have a complex animation system. Open Animation Tree Editor

Minimal reproduction project (MRP)

N/A
@AThousandShips AThousandShips moved this from Unassessed to Immediate Blocker in 4.x Release Blockers Feb 3, 2025
@AThousandShips AThousandShips added this to the 4.4 milestone Feb 3, 2025
@AThousandShips
Copy link
Member

CC @Nazarwadim

@AThousandShips
Copy link
Member

Please upload an MRP to help test this, as it requires a bit more specific conditions

@eddieataberk
Copy link
Author

Please upload an MRP to help test this, as it requires a bit more specific conditions

Working on it but as I mentioned on the commit It's a quite complex anim tree. I am not sure if its something specific in the anim tree i was working on or maybe caused by opening an anim tree crated in the old version.

@AThousandShips
Copy link
Member

That would be critical information to test this so if you're able to figure that out it would help a lot!

@akien-mga
Copy link
Member

Since you're compiling from source, can you confirm that reverting 96a6dc2 locally on top of the latest master branch solves the issue?

This was an optimization so if we're not able to identify quickly what causes it to crash, it's probably best to revert for now, and revisit this for 4.5 with more testing. But eventually we'd need to understand why it causes a crash anyway if we want to merge it again.

@Nazarwadim Nazarwadim mentioned this issue Feb 3, 2025
Closed
@eddieataberk
Copy link
Author

Since you're compiling from source, can you confirm that reverting 96a6dc2 locally on top of the latest master branch solves the issue?

This was an optimization so if we're not able to identify quickly what causes it to crash, it's probably best to revert for now, and revisit this for 4.5 with more testing. But eventually we'd need to understand why it causes a crash anyway if we want to merge it again.

Just tested. Reverting changes solves the problem.
Image

This was referenced Feb 4, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug crash regression topic:animation topic:editor
Projects
4.x Release Blockers
Status: Immediate Blocker
Milestone
4.4
3 participants
@akien-mga @eddieataberk @AThousandShips