Use AHashMap for RBMap nodes and HashMap input_activity (reverted)

[Nazarwadim]

Forgot to change in #92554

Gives 15% more FPS on MPR from #101494.

Helps with #101494

[akien-mga]

Gives 15% more FPS on MPR from #101494.

Probably closes #101494

That's amazing! 🎉
I wouldn't say that it closes #101494 though, it seems like we're still far from ideal performance targets. If 3.x was 50% faster than 4.x, even by reclaiming 15% off it we still have a way to go.

[Nazarwadim]

@akien-mga See this comment #101494 (comment)

In 4.3, for some reason, two animations are played due to the combination of AnimationPlayer and AnimationMixer. The first is empty from AnimationPlayer, which does nothing, but only takes resources, and the second is real from AnimationTree.

So if this will be merged in 4.4 we will get 20% faster animation compared to 3.6.

Edit: For some reason, it is only for me.

[TokageItLab]

I am not familiar with AHashMap, but doesn't it change the sorting order as the hash seed is changed with each startup? If so, this argument is needed to avoid to change .tres. Resolved as AHashMap doesn't change index order.

[Repiteo]

Thanks!

[akien-mga]

Reverting with #102432 to fix #102374, but this is worth looking into again for 4.5 as the gains seemed to be substantial.

[eddieataberk]

Reverting with #102432 to fix #102374, but this is worth looking into again for 4.5 as the gains seemed to be substantial.

#102376
This is pr closed but i highly recommend merging it. I've been using it in a very complex anim tree since yesterday with no issues.

[clayjohn]

@Nazarwadim Can you open a new PR with these changes combined with #102376 ?