MeshInstance3D: Implement the use of overriden virtual _get_aabb #100808
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to Make GeometryInstance3D accessible for custom Geometry Scenes (and implementing the alternative approach)
There is a virtual method
_get_aabbin VisualInstance3D->MeshInstance3D that cannot be used in GDScript anymore because it is routed to the Mesh. If there is no Mesh an empty AABB is returned. This PR fixes this so that if there is no Mesh, the GDScript overriden_get_aabbin MeshInstance3D is used.[debug]meshinstance3d_get_aabb.zip