Add right click popup options in Connections to Method dialog. #100814
+356
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to have 2 separate "Go to Source Node" and "Go to Target Node" options instead of the same item changing behavior depending on where the user clicks. The discover ability would be better that way IMO. Great addition anyways! |
dmgsoftware
force-pushed
the
connections-to-method-dialog
branch
2 times, most recently
from
8b5ce11 to
abb0746
Compare
|
@JoNax97 Thank you for the comment. I hadn't thought of that, but it is definitely the more intuitive approach. I went ahead pushed those changes. |
|
Does double clicking on the node works the same as "Shows node in Tree"? |
dmgsoftware
force-pushed
the
connections-to-method-dialog
branch
from
abb0746 to
7d82b89
Compare
|
@Lazy-Rabbit-2001 That's a good idea! I just pushed those changes. Thanks for the suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections to method is quite baron in it’s current read-only form, lacking quick access to useful connection functionality. In this pull request I have added the following right click options:
2. Show Node in TreeI decided to preserve the ordering found in the signals tab for consistency.
However, I did switch out “Go to Method” in lieu of the “Show Node in Tree” option because we had to come from the method to open this dialog.Double clicking on either the source node or target node will show the node in the tree.
Show Node in Tree goes to the appropriate node for both source and target, and signal defaults to using the source node.Closes godotengine/godot-proposals#1849
Closes godotengine/godot-proposals#10840