Add Color.from_rgba8 and deprecate Color8 #100825
Open
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
Dec 26, 2024
There was a problem hiding this comment.
Kind of has been in the wrong place for a really long time, ever since exposing static methods became possible. The logic has been ridiculously simplified, too.
I'm not sure how exactly to go about this but the original Color8 needs to be surrounded by #ifndef DISABLE_DEPRECATED blocks.
KoBeWi
force-pushed
the
colored_eight
branch
from
b6672a9 to
4e48b19
Compare
Mickeon
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30499