Skip to content

Save LightmapGI shadowmask to a lossless WebP image to reduce file size #101881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −2
Open

Save LightmapGI shadowmask to a lossless WebP image to reduce file size #101881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions scene/3d/lightmap_gi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ LightmapGI::BakeError LightmapGI::_save_and_reimport_atlas_textures(const Ref<Li
texture_image->blit_rect(images[i * slices_per_texture + j], Rect2i(0, 0, slice_width, slice_height), Point2i(0, slice_height * j));
}

const String atlas_path = (texture_count > 1 ? p_base_name + "_" + itos(i) : p_base_name) + (p_is_shadowmask ? ".png" : ".exr");
const String atlas_path = (texture_count > 1 ? p_base_name + "_" + itos(i) : p_base_name) + (p_is_shadowmask ? ".webp" : ".exr");
const String config_path = atlas_path + ".import";

Ref<ConfigFile> config;
Expand Down Expand Up @@ -865,7 +865,19 @@ LightmapGI::BakeError LightmapGI::_save_and_reimport_atlas_textures(const Ref<Li
// Save the file.
Error save_err;
if (p_is_shadowmask) {
save_err = texture_image->save_png(atlas_path);
// Downsize the image if needed to fit within the WebP format limitations.
// In practice, the maximum usable texture size is typically 16384×16384,
// so this only changes the size by 1 pixel which is unnoticeable.
constexpr int WEBP_SIZE_LIMIT = 16383;
if (texture_image->get_width() > WEBP_SIZE_LIMIT) {
texture_image->resize(WEBP_SIZE_LIMIT, texture_image->get_height() * WEBP_SIZE_LIMIT / texture_image->get_width());
} else if (texture_image->get_height() > WEBP_SIZE_LIMIT) {
texture_image->resize(texture_image->get_width() * WEBP_SIZE_LIMIT / texture_image->get_height(), WEBP_SIZE_LIMIT);
}
// Save as lossless WebP instead of PNG to reduce file size in the project files.
// The exported project size will remain identical, but this reduces the size of the file
// that is committed to version control.
save_err = texture_image->save_webp(atlas_path);
} else {
save_err = texture_image->save_exr(atlas_path, false);
}
Expand Down