Fix reflection probes working in stereo on compatibility renderer #102447
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering in stereo we do not do our right-side-up rendering of the main buffer. There seems to be a condition where our culling direction remains reversed which stopped the cubemap filter from working and copying the final mipmap results of the reflection probe leaving the contents of the reflection probe empty.
Disabling culling before performing the cubemap filter ensures we always perform the process.
Note that when the reflection probe is set to once, it can take over 6 frames before the reflection probe is populated with data as we render one side of the reflection probe per frame to save performance. So for the first 6 to 15 frames the reflection probe still remains black in the MRP supplied on the bug report causing the pillars to not be lit up correctly.
Fixes #102443