Bandaid fix for dim lightmaps when using directional toggle #102723
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still trying to find the root cause of the issue but thought this might be worth discussing. |
Rudolph-B
force-pushed
the
Issue-102300
branch
from
5dd6f59 to
6bb3c8c
Compare
Rudolph-B
force-pushed
the
Issue-102300
branch
from
6bb3c8c to
9a6bb58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102300, Although not properly.
I changed a attenuation factor from
dot(p_normal, r_light_dir)to besqrt(dot(p_normal, r_light_dir)). This only gets applied to omni and spot lights in the directional case. This seemed to minimize the differences between other lighting methods.The example shown where baked with a texel scale of 16 using the mrp in #102300:
lightmap4dot4beta2.zip
Spotlight:
Omnilight: