-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for return value of Packed*Array.resize
#104258
Improve documentation for return value of Packed*Array.resize
#104258
Conversation
The Array equivalent of this method already has a more suitable way of describing this (since #69451):
I would suggest copying it. I don't think the way it is described in this PR (as of writing this) is clear or concise. |
Packed*Array.resize
Should we merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For now this would be fine, but it could be worth looking into:
|
The lack of Related: |
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
0a5ea67
to
44d10c5
Compare
I went ahead and documented this, and made things further consistent with Array. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Changed the documentation to specify the return value of the resize() function because of this issue from the godot docs repo.