Add multi-node 3D collision based snapping#106794
Open
ryevdokimov wants to merge 1 commit intogodotengine:masterfrom
Open
Add multi-node 3D collision based snapping#106794ryevdokimov wants to merge 1 commit intogodotengine:masterfrom
ryevdokimov wants to merge 1 commit intogodotengine:masterfrom
Conversation
ryevdokimov
force-pushed
the
multi-node-collision-snapping
branch
from
4aa88ed to
c8aed3a
Compare
ryevdokimov
force-pushed
the
multi-node-collision-snapping
branch
from
c8aed3a to
5b96348
Compare
ryevdokimov
force-pushed
the
multi-node-collision-snapping
branch
from
5b96348 to
cc51d8f
Compare
ryevdokimov
force-pushed
the
multi-node-collision-snapping
branch
from
cc51d8f to
05b4088
Compare
ryevdokimov
force-pushed
the
multi-node-collision-snapping
branch
from
05b4088 to
7a94431
Compare
ryevdokimov
force-pushed
the
multi-node-collision-snapping
branch
from
7a94431 to
9b80537
Compare
fire
approved these changes
Apr 29, 2026
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
Reviewed code
Did not quality assurance test.
fire
reviewed
Apr 29, 2026
| if (selection.size() == 1) { | ||
| selected_node = Object::cast_to<Node3D>(selection.front()->get()); | ||
| } else { | ||
| Node3D *active_node = spatial_editor->get_active_node(); |
Member
There was a problem hiding this comment.
If the nesting is too deep, we tend to use guard clause style in c++.
Contributor
Author
There was a problem hiding this comment.
Done and retested.
ryevdokimov
force-pushed
the
multi-node-collision-snapping
branch
from
9b80537 to
5a711b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#96740 added the ability to snap 3D nodes using collisions. This PR adds the ability to do it with multiple nodes selected.
447321991-e4224404-cc04-43de-afac-032a5d20b882.1.mp4