Add ConstIterator conversions for missing container Iterators#109823
Open
Spartan322 wants to merge 1 commit intogodotengine:masterfrom
Open
Add ConstIterator conversions for missing container Iterators#109823Spartan322 wants to merge 1 commit intogodotengine:masterfrom
ConstIterator conversions for missing container Iterators#109823Spartan322 wants to merge 1 commit intogodotengine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterators toConstIterators godot-proposals#13036ConstIteratorconversions for missing containerIterators godot-cpp#1835This is more an address of an inconsistency of the iterators, for some container iterators already had a conversion operator but not every container with an
Iteratorstruct did, this is rounding out the remainder of the iterators that should. To minimize changes and keep consistency this follows the implementation common among the containers that already performed the conversion. This is mostly just to synchronize for GDExtensions.