Use additive blending for suns in ProceduralSkyMaterial to fix dark suns #113292
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents dark DirectionalLight3D colors from creating splotches in the sky, which is a commonly encountered issue when working on day/night cycle systems.
This affects how bright suns are rendered too, with a greater impact on heavily saturated colors.
If we consider the visual difference to be too important, we'll probably want to add a Sun Blend Mode property to control this (although ProceduralSkyMaterial is already quite complex as it is). If we want a compatible solution that still addresses the original issue, we could perform premultiplied alpha blending instead, with the "alpha" value being determined by the color's HSV value.
Testing project: test_sky_sun.zip
Preview
The scene has 4 suns.