Fix GPU & CPU Particle Gizmos deforming based on CanvasItem#114720
Open
ColinSORourke wants to merge 1 commit intogodotengine:masterfrom
Open
Fix GPU & CPU Particle Gizmos deforming based on CanvasItem#114720ColinSORourke wants to merge 1 commit intogodotengine:masterfrom
ColinSORourke wants to merge 1 commit intogodotengine:masterfrom
Conversation
Adds a redundant Gizmo_Canvas_Item to GPU & CPU Particles2D, which is used to draw Visibility and Emission Gizmos independently of the original canvas item (resolving the issue where these gizmos would deform based on CanvasItem Particle_Anim) Also moves Circle & Rect Outline Calculation to Geometry2D for Code simplification.
ColinSORourke
force-pushed
the
ParticleEmissionDeformFix
branch
from
48254a6 to
7127a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #111677, resolves #89896
Adds an extra Gizmo_Canvas_Item to GPU & CPU Particles2D, which is used to draw Visibility and Emission Gizmos independently of the original canvas item (resolving the issue where these gizmos would deform based on CanvasItem Particle_Anim)
Also moves Circle & Rect Outline Calculation to Geometry2D for Code simplification.