Add tree filtering to Advanced Import Settings#117826
Add tree filtering to Advanced Import Settings#117826jeronimo-schreyer wants to merge 1 commit intogodotengine:masterfrom
Conversation
5dd955b to
8571f35
Compare
8571f35 to
793a352
Compare
878c6cf to
8145c79
Compare
8145c79 to
7d1805d
Compare
19aaaf7 to
ea487d3
Compare
KoBeWi
left a comment
There was a problem hiding this comment.
There are some minor problems, but otherwise looks fine.
That TreeSortAndFilterBar looks neat and questionable at the same time. We could probably use it in more places, but the code needs some improvements.
09c9872 to
02d58f8
Compare
bfa38e2 to
20e2b82
Compare
* Implements node and resource filtering in the scene import settings dialog. * Moved TreeSortAndFilterBar class from ObjectDB Profiler module to the `editor/` folder so its available for every other Tree in the editor that has filtering. Added editor\gui\tree_sort_and_filter_line_edit.cpp editor\gui\tree_sort_and_filter_line_edit.h Updated editor\import\3d\scene_import_settings.cpp editor\import\3d\scene_import_settings.h modules\objectdb_profiler\editor\data_viewers\class_view.cpp modules\objectdb_profiler\editor\data_viewers\node_view.h modules\objectdb_profiler\editor\data_viewers\object_view.h modules\objectdb_profiler\editor\data_viewers\refcounted_view.h modules\objectdb_profiler\editor\data_viewers\shared_controls.cpp modules\objectdb_profiler\editor\data_viewers\shared_controls.h
20e2b82 to
3453eb1
Compare
|
Tested it. This is a great improvement. The only thing that's lacking is that the search query resets when you go into a different tab and back. |
I'd say that's actually a feature, materials and meshes might have different names and chaging tabs and then applying the search could be confusing for the user. I could insert different filters inside each tab and then each tab wouldn't need to clear the filter everytime though but we've already discussed with @KoBeWi to leave only one |
That's exactly what I am talking about. Can be done in another PR I suppose. |
editor/folder so its available for every other Tree in the editor that has filtering.Added
editor\gui\tree_sort_and_filter_line_edit.cpp
editor\gui\tree_sort_and_filter_line_edit.h
Updated
editor\import\3d\scene_import_settings.cpp
editor\import\3d\scene_import_settings.h
modules\objectdb_profiler\editor\data_viewers\class_view.cpp
modules\objectdb_profiler\editor\data_viewers\node_view.h
modules\objectdb_profiler\editor\data_viewers\object_view.h
modules\objectdb_profiler\editor\data_viewers\refcounted_view.h
modules\objectdb_profiler\editor\data_viewers\shared_controls.cpp
modules\objectdb_profiler\editor\data_viewers\shared_controls.h
Bugsquad edit: This closes godotengine/godot-proposals#6764.