Skip to content

Add tree filtering to Advanced Import Settings#117826

Open
jeronimo-schreyer wants to merge 1 commit intogodotengine:masterfrom
jeronimo-schreyer:filtering_feature_in_resource_importer
Open

Add tree filtering to Advanced Import Settings#117826
jeronimo-schreyer wants to merge 1 commit intogodotengine:masterfrom
jeronimo-schreyer:filtering_feature_in_resource_importer

Conversation

@jeronimo-schreyer
Copy link
Copy Markdown
Contributor

@jeronimo-schreyer jeronimo-schreyer commented Mar 25, 2026

  • Implements node and resource filtering in the scene import settings dialog.
  • Moved TreeSortAndFilterBar class from ObjectDB Profiler module to the editor/ folder so its available for every other Tree in the editor that has filtering.

Added
editor\gui\tree_sort_and_filter_line_edit.cpp
editor\gui\tree_sort_and_filter_line_edit.h

Updated
editor\import\3d\scene_import_settings.cpp
editor\import\3d\scene_import_settings.h
modules\objectdb_profiler\editor\data_viewers\class_view.cpp
modules\objectdb_profiler\editor\data_viewers\node_view.h
modules\objectdb_profiler\editor\data_viewers\object_view.h
modules\objectdb_profiler\editor\data_viewers\refcounted_view.h
modules\objectdb_profiler\editor\data_viewers\shared_controls.cpp
modules\objectdb_profiler\editor\data_viewers\shared_controls.h

Bugsquad edit: This closes godotengine/godot-proposals#6764.

@jeronimo-schreyer jeronimo-schreyer requested review from a team as code owners March 25, 2026 13:25
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch from 5dd955b to 8571f35 Compare March 25, 2026 13:27
@AThousandShips AThousandShips added this to the 4.x milestone Mar 25, 2026
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch from 8571f35 to 793a352 Compare March 25, 2026 13:28
Comment thread editor/import/3d/scene_import_settings.cpp Outdated
Comment thread editor/import/3d/scene_import_settings.cpp Outdated
Comment thread editor/import/3d/scene_import_settings.h Outdated
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch 2 times, most recently from 878c6cf to 8145c79 Compare March 25, 2026 13:42
@lyuma lyuma moved this to Ready for review in Asset Pipeline Issue Triage Mar 25, 2026
youfch added a commit to youfch/godot that referenced this pull request Mar 27, 2026
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch from 8145c79 to 7d1805d Compare April 6, 2026 17:30
@jeronimo-schreyer jeronimo-schreyer requested a review from a team as a code owner April 6, 2026 17:30
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch 6 times, most recently from 19aaaf7 to ea487d3 Compare April 6, 2026 18:44
@jeronimo-schreyer jeronimo-schreyer requested a review from KoBeWi April 9, 2026 15:44
Copy link
Copy Markdown
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor problems, but otherwise looks fine.

That TreeSortAndFilterBar looks neat and questionable at the same time. We could probably use it in more places, but the code needs some improvements.

Comment thread editor/gui/tree_sort_and_filter_line_edit.cpp Outdated
Comment thread editor/gui/tree_sort_and_filter_line_edit.h Outdated
Comment thread editor/import/3d/scene_import_settings.cpp
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch 2 times, most recently from 09c9872 to 02d58f8 Compare April 22, 2026 20:50
@KoBeWi KoBeWi modified the milestones: 4.x, 4.8 Apr 23, 2026
Comment thread editor/import/3d/scene_import_settings.h Outdated
Comment thread editor/gui/tree_sort_and_filter_line_edit.h Outdated
Comment thread modules/objectdb_profiler/editor/data_viewers/refcounted_view.h Outdated
Comment thread modules/objectdb_profiler/editor/data_viewers/object_view.h Outdated
Comment thread modules/objectdb_profiler/editor/data_viewers/node_view.h Outdated
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch 2 times, most recently from bfa38e2 to 20e2b82 Compare April 24, 2026 12:45
* Implements node and resource filtering in the scene import settings dialog.
* Moved TreeSortAndFilterBar class from ObjectDB Profiler module to the `editor/` folder so its available for every other Tree in the editor that has filtering.

Added
editor\gui\tree_sort_and_filter_line_edit.cpp
editor\gui\tree_sort_and_filter_line_edit.h

Updated
editor\import\3d\scene_import_settings.cpp
editor\import\3d\scene_import_settings.h
modules\objectdb_profiler\editor\data_viewers\class_view.cpp
modules\objectdb_profiler\editor\data_viewers\node_view.h
modules\objectdb_profiler\editor\data_viewers\object_view.h
modules\objectdb_profiler\editor\data_viewers\refcounted_view.h
modules\objectdb_profiler\editor\data_viewers\shared_controls.cpp
modules\objectdb_profiler\editor\data_viewers\shared_controls.h
@jeronimo-schreyer jeronimo-schreyer force-pushed the filtering_feature_in_resource_importer branch from 20e2b82 to 3453eb1 Compare April 24, 2026 12:50
Copy link
Copy Markdown
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romgerman
Copy link
Copy Markdown
Contributor

Tested it. This is a great improvement. The only thing that's lacking is that the search query resets when you go into a different tab and back.

@jeronimo-schreyer
Copy link
Copy Markdown
Contributor Author

Tested it. This is a great improvement. The only thing that's lacking is that the search query resets when you go into a different tab and back.

I'd say that's actually a feature, materials and meshes might have different names and chaging tabs and then applying the search could be confusing for the user. I could insert different filters inside each tab and then each tab wouldn't need to clear the filter everytime though but we've already discussed with @KoBeWi to leave only one

@romgerman
Copy link
Copy Markdown
Contributor

I could insert different filters inside each tab and then each tab wouldn't need to clear the filter everytime

That's exactly what I am talking about. Can be done in another PR I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

Add node tree filter/search to Advanced Import Settings

5 participants