Improve movie writer low disk space: check is specific to path instead of filesystem#118924
Open
aurpine wants to merge 1 commit intogodotengine:masterfrom
Open
Improve movie writer low disk space: check is specific to path instead of filesystem#118924aurpine wants to merge 1 commit intogodotengine:masterfrom
aurpine wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
Author
Calinou
approved these changes
Apr 27, 2026
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Member
aurpine
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirAccess::openis a static method with no side effects aside from object creation. In this context, the return value is unused. I believe this is a mistake and the intention was not to call this for the side-effects of checking if the path can be opened.As a result of the change, the space check will now be specific to the path.