[macOS] Align menu items between separators.#118953
Open
bruvzg wants to merge 1 commit intogodotengine:masterfrom
Open
[macOS] Align menu items between separators.#118953bruvzg wants to merge 1 commit intogodotengine:masterfrom
bruvzg wants to merge 1 commit intogodotengine:masterfrom
Conversation
AdriaandeJongh
approved these changes
Apr 25, 2026
Contributor
AdriaandeJongh
left a comment
There was a problem hiding this comment.
Reviewed based on the screenshots. I'm not 100% sure about how the Export as > doesn't get indented when the rest of the menu does, but regardless: this helps making the more important options more prominent.
Didn't look at the code.
Member
Author
That's how it is done in most macOS apps, but aligning everything might be better (and can simplify code a bit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly relevant in combination with #65229
Built-in Godot menus align everything to an icon, but aligning only items between separators matches the way default macOS app handle it:
