Skip to content

[macOS] Align menu items between separators.#118953

Open
bruvzg wants to merge 1 commit intogodotengine:masterfrom
bruvzg:mac_menu_align
Open

[macOS] Align menu items between separators.#118953
bruvzg wants to merge 1 commit intogodotengine:masterfrom
bruvzg:mac_menu_align

Conversation

@bruvzg
Copy link
Copy Markdown
Member

@bruvzg bruvzg commented Apr 25, 2026

Mostly relevant in combination with #65229

Before After
Screenshot 2026-04-25 at 16 55 24 Screenshot 2026-04-25 at 16 50 40

Built-in Godot menus align everything to an icon, but aligning only items between separators matches the way default macOS app handle it:
Screenshot 2026-04-25 at 16 51 44

@bruvzg bruvzg added this to the 4.x milestone Apr 25, 2026
@bruvzg bruvzg requested a review from a team as a code owner April 25, 2026 13:59
Copy link
Copy Markdown
Contributor

@AdriaandeJongh AdriaandeJongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed based on the screenshots. I'm not 100% sure about how the Export as > doesn't get indented when the rest of the menu does, but regardless: this helps making the more important options more prominent.

Didn't look at the code.

@bruvzg
Copy link
Copy Markdown
Member Author

bruvzg commented Apr 26, 2026

I'm not 100% sure about how the Export as > doesn't get indented when the rest of the menu does, but regardless: this helps making the more important options more prominent.

That's how it is done in most macOS apps, but aligning everything might be better (and can simplify code a bit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants