Remove redundant ClearData struct from GDScript#118957
Open
DeeJayLSP wants to merge 1 commit intogodotengine:masterfrom
Open
Remove redundant ClearData struct from GDScript#118957DeeJayLSP wants to merge 1 commit intogodotengine:masterfrom
ClearData struct from GDScript#118957DeeJayLSP wants to merge 1 commit intogodotengine:masterfrom
Conversation
DeeJayLSP
force-pushed
the
gds-redundant-cleardata
branch
from
c4e6417 to
3b9ad3d
Compare
DeeJayLSP
force-pushed
the
gds-redundant-cleardata
branch
from
3b9ad3d to
01dcf6a
Compare
HolonProduction
approved these changes
Apr 26, 2026
Member
HolonProduction
left a comment
HolonProduction
left a comment
There was a problem hiding this comment.
Yeah, forgot to remove this in #114801. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was introduced in #71028, but its entire purpose was later removed in #114801, which likely missed this. It's not used anywhere and there's no
ClearDatain the codebase other than this sole definition.The inclusion of
rb_set.hgets moved fromgdscript.htogdscript.cppandgdscript_cache.cpp, to makeclangd-tidyhappy.