Backport improved look_at docs #57475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snailrhymer
force-pushed
the
look-at-update
branch
from
7d48648
to
a328a13
Compare
Take extra constraint info and function description from Node3D.look_at to improve Spatial.look_at docs. Add an explicit error for up == 0
snailrhymer
force-pushed
the
look-at-update
branch
from
a328a13
to
83298da
Compare
|
Also added 4.0's error message for up == 0. Is it worth copying over the default up as (0,1,0)? |
aaronfranke
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
See #50682 for reference. We could also backport the Transform documentation (Transform3D in master).
The methods changed in that PR have the same behavior aside from more performance and better checks. They might have tiny floating point differences so it's safest to not backport them but backporting the docs for them is fine because the behavior is identical.
Is it worth copying over the default up as (0,1,0)?
I'm not sure if this breaks ABI compatibility, but it should be fine for API compatibility, I think...? See #45575 for reference.
|
Thanks! |
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take extra constraint info and function description from Node3D.look_at to improve Spatial.look_at docs.
The implementations of Spatial.look_at and Node3D.look_at are marginally different, but all the claims appear to still be valid.
Resolves #57457.