[AnimatedSprite] Implement duplicate animations #57949
Conversation
|
That's great. One thing I believe could be done on top of it is duplicating the animation name, as well, but adding an incrementing number to it. (e.g. "anim" duplicates into "anim2", then "anim3", and so on). It would keep it in line with the SceneTree duplication behaviour. |
| @@ -0,0 +1 @@ | |||
| * [32m3942[m | |||
There was a problem hiding this comment.
This file has to be removed :)
| @@ -662,13 +663,43 @@ void SpriteFramesEditor::_animation_add() { | |||
| undo_redo->add_do_method(E, "set_animation", name); | |||
| undo_redo->add_undo_method(E, "set_animation", current); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These trailing spaces have to be removed.
| edited_anim = name; | ||
|
|
||
| undo_redo->commit_action(); | ||
| animations->grab_focus(); | ||
| } | ||
|
|
||
| void SpriteFramesEditor::_animation_duplicate() { | ||
| if ( !frames->has_animation(edited_anim) ) { |
There was a problem hiding this comment.
| if ( !frames->has_animation(edited_anim) ) { | |
| if (!frames->has_animation(edited_anim)) { |
I wonder why CI did not detect this :(
|
|
||
| StringName anim_to_duplicate = edited_anim; | ||
| int duplicate_frame_count = frames->get_frame_count(anim_to_duplicate); | ||
| String new_name = String(edited_anim); //Get the animation name to duplicate, cant use the anim_to_duplicate since its a StringName and cannot be modified |
There was a problem hiding this comment.
For comments, it's prefered to start with // (with an empty space following //) and end with a period. Serveral other comments need to be fixed too.
| int counter = 1; | ||
| while(frames->has_animation(new_name + "_" + itos(counter))) { | ||
| counter++; | ||
| } | ||
| new_name = new_name + "_" + itos(counter); | ||
| frames->rename_animation(edited_anim,new_name); |
There was a problem hiding this comment.
This is inconsistent with how _animation_add() handles name conflicts. It uses "Existing Name N" while this uses "Existing Name_N". I think they should be unified.
Also, there should be a space between while and (. More style issues can be found by running clang-format, see Code Style Guide.
Implements #3942
PS:
Edit:
Just added @Mickeon's idea, to use the duplicated animation's name: