Add wireframe for compatibility mode

[daustria]

The implementation for wireframe mode is mostly the same as the one in 4d50c7a
which is used in Godot 3.5

• Production edit: This partially addresses OpenGL: Debug draw modes are not working #82485.

[fire]

Hi,

I noticed this is your first time contributing to Godot Engine. The Github actions which tests for acceptability to merge has found an error with your formatting.

Please see https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html for more details.

Let me know if you have questions.

[fire]

I think this is wanted, but @clayjohn knows more about adding wireframe modes to the Godot Engine 4 compatibility renderer.

[clayjohn]

This looks mostly good. Great work!

I left a few suggestions for improvements, mostly just style stuff to help this pass CI, but I left one important suggestion to clean up the implementation a bit

[daustria]

sorry about the styling issues, i think i finally figured out how to properly use clang-format
edit: seems not

[AThousandShips]

You still haven't fixed the whitespace, you must not have applied clang-format correctly

[AThousandShips]

Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

[Calinou]

Tested locally (rebased on top of master d76c1d0), it mostly works as expected.

However, when using OpenGL, wireframe mode doesn't work in a running project (running with editor binary). Instead, it only works if it's toggled within the editor. This is inconsistent with Forward+/Mobile where you can change the debug draw mode to Wireframe at runtime in a debug build.

It can be useful to support this to debug procedurally generated geometry, so I'd recommend looking into fixing this issue.

func _ready():
	get_viewport().debug_draw = Viewport.DEBUG_DRAW_WIREFRAME

Testing project: test_lightmapgi_mobile.zip

Mobile	Compatibility

[clayjohn]

However, when using OpenGL, wireframe mode doesn't work in a running project (running with editor binary). Instead, it only works if it's toggled within the editor. This is inconsistent with Forward+/Mobile where you can change the debug draw mode to Wireframe at runtime in a debug build.

It can be useful to support this to debug procedurally generated geometry, so I'd recommend looking into fixing this issue.

This is actually by design. The OpenGL renderer needs to generate a store the wireframe versions of the meshes. It would be hugely wasteful to do that at runtime.

I think that the current behaviour is preferrable (and matches 3.x) If you need the debug wireframes at runtime, you need to request them with RenderingServer.set_debug_generate_wireframes()

[clayjohn]

Looks good to me! Great work

[clayjohn]

Tagged for cherrypicking. But might not be best for a 4.2.1 if we want 4.2.1 to be ultra-safe. This isn't a high priority cherrypick, but it would be nice to have in 4.2.x eventually.

[YuriSizov]

@daustria Just FYI this commit is attributed to an email which is not linked to your account. This does not prevent us from merging it, but just be aware that you need to link your email for this to count towards your contributions to the project. See this.

[YuriSizov]

Thanks! And congrats on your first merged contribution to the engine!

[YuriSizov]

Cherry-picked for 4.2.2.