Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duplicate animation for SpriteFrames #93624

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add duplicate animation for SpriteFrames #93624

merged 1 commit into from
Sep 3, 2024

Conversation

EAinsley
Copy link
Contributor

@EAinsley EAinsley commented Jun 26, 2024 •
edited by AThousandShips
Loading

This is a continue work of #80380.
Close godotengine/godot-proposals#3942.

anim.tscn.-.Testing.-.Godot.Engine.2024-06-26.17-31-34.mp4

@EAinsley EAinsley requested a review from a team as a code owner June 26, 2024 09:43
@AThousandShips AThousandShips added this to the 4.x milestone Jun 26, 2024
@AThousandShips AThousandShips requested a review from a team June 26, 2024 09:45
@AThousandShips
Copy link
Member

You've made them the author and made yourself the co author, it should be the other way around

@Mickeon Mickeon requested a review from KoBeWi June 26, 2024 09:55
@EAinsley
Copy link
Contributor Author

You've made them the author and made yourself the co author, it should be the other way around

It was intentional. I thought he did most of the work. Anyway, updated.

Mickeon
Mickeon reviewed Jun 26, 2024
View reviewed changes
scene/resources/sprite_frames.cpp Outdated Show resolved Hide resolved
doc/classes/SpriteFrames.xml Outdated Show resolved Hide resolved
KoBeWi
KoBeWi approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but it works correctly.

@EAinsley
Copy link
Contributor Author

Left some comments, but it works correctly.

Thank you! They are really helpful.

@EAinsley
Copy link
Contributor Author

Would this be merged?

@akien-mga
Copy link
Member

We're in feature freeze for Godot 4.3, so this kind of change would be merged after the 4.3 release is done, for 4.4.

@Mickeon Mickeon mentioned this pull request Jun 30, 2024
Closed
@EAinsley @nonunknown777
Add duplicate animation
57bc1d7 
Co-authored-by: Nonunknown <[email protected]>
@Mickeon
Copy link
Contributor

Mickeon commented Sep 1, 2024 •
edited
Loading

Thank you for your rebase. I'm moving this to 4.4 as it's a long-standing requested feature that is relatively minor in scope.

@Mickeon Mickeon modified the milestones: 4.x, 4.4 Sep 1, 2024
@akien-mga akien-mga merged commit 5633080 into godotengine:master Sep 3, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@EAinsley EAinsley deleted the complete#3942 branch September 30, 2024 09:23
@jasonmorgado jasonmorgado mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Add a Duplicate button and context menu to the SpriteFrames editor
5 participants
@EAinsley @AThousandShips @akien-mga @Mickeon @KoBeWi