Use PackedVector4Array instead of float array for vec4 array uniform
#93635
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had the same change suggested in #85474 (comment) indeed, but wasn't sure it was the only place where it needs to be changed. If you've tested that the functionality still works as expected, including loading vec4 array uniforms saved in previous engine versions, this should be good to go. |
Chaosus
force-pushed
the
shader_fix_vec4_uniform
branch
3 times, most recently
from
ba70b42
to
5e450df
Compare
akien-mga
reviewed
Jun 28, 2024
akien-mga
approved these changes
Jun 28, 2024
Chaosus
force-pushed
the
shader_fix_vec4_uniform
branch
from
5e450df
to
72c7e51
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a good fix.