Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PackedVector4Array instead of float array for vec4 array uniform #93635

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 26, 2024

I think it's a good fix.

@Chaosus Chaosus requested a review from a team as a code owner June 26, 2024 14:13
@Chaosus Chaosus added this to the 4.3 milestone Jun 26, 2024
@akien-mga
Copy link
Member

I had the same change suggested in #85474 (comment) indeed, but wasn't sure it was the only place where it needs to be changed.

If you've tested that the functionality still works as expected, including loading vec4 array uniforms saved in previous engine versions, this should be good to go.

@Chaosus Chaosus force-pushed the shader_fix_vec4_uniform branch 3 times, most recently from ba70b42 to 5e450df Compare June 28, 2024 10:20
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with added compat code.

@akien-mga akien-mga merged commit a365cf5 into godotengine:master Jun 28, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_fix_vec4_uniform branch June 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants