Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Add new local hook semicolon-cleanup #93637

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jun 26, 2024

Originally part of #93313, this PR seeks to fix a style inconsistency that revealed itself after updating clang-format: unnecessary trailing semicolons. While ultimately harmless, as we are erring more towards reintegrating clang-format/clang-tidy into the overall workflow, this hook will operate like other formatting hooks to keep our codebase consistent. Like other hook PRs, the whitespace changes and .git-blame-ignore-revs exclusion were handled as separate, subsequent commits.

@Repiteo
Copy link
Contributor Author

Repiteo commented Jul 5, 2024

Converting to draft, as I think there's a way to integrate this with clang directly.

@Repiteo Repiteo marked this pull request as draft July 5, 2024 17:22
@Repiteo Repiteo modified the milestones: 4.3, 4.x Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant