Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make push_error and push_warning print name of calling function #93648

Open
wants to merge 81 commits into
base: master
Choose a base branch
from

Commits on Jun 27, 2024

  1. Allow constructing Lists from initializer_lists

    QOL improvement to allow direct construction of `List`s.
    TV4Fun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1aaa831 View commit details
    Browse the repository at this point in the history
  2. Make push_error and push_warning print name of calling function

    Currently, `push_error` and `push_warning` give themselve as the calling
    function, which is not useful for debugging. I have altered these to use the
    C stacktrace to get the name of the function that called them. This saves
    having to turn these functions into macros, which would require recompiling
    every single piece of code that uses them. I have also set it to, when debug
    symbols are available, use them with `atos` (available on macOS) to find the
    exact source file and line being called from. It should be possible to the same
    thing on Linux using `addr2line`, but I don't have a Linux box handy to test
    that. I am not sure how you would implement this in Windows.
    
    I have tested this on macOS Sonoma 14.5 (23F79). It should work on any *nix
    system. I am not sure about Windows.
    
    Fixes godotengine#76770
    TV4Fun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1a75580 View commit details
    Browse the repository at this point in the history
  3. Fix code style issues

    TV4Fun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    60b85b5 View commit details
    Browse the repository at this point in the history
  4. Move C++ code line discovery to its own function

    Also add method to print whole callstack.
    TV4Fun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ebdcbb8 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    0b950f5 View commit details
    Browse the repository at this point in the history
  2. Try fix for Linux builds

    The Linux build breaks on `OS_Unix` because `Dl_info` is not `typedef`ed as
    `struct dl_info`, so the forward declaration of that struct breaks. Changing
    the forward declaration to `struct Dl_info` breaks the Mac build though, so
    that leaves us with some `#ifdef`s. This may or may not work, I'll have to see.
    TV4Fun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1e21798 View commit details
    Browse the repository at this point in the history
  3. Actual fix for Linux builds

    Okay, there doesn't actually seem to be a way to forward declare a `typedef`
    to an anonymous `struct`. So, rather than include an unnecessary system header
    in `os_unix.h`, I am now just passing the members of `Dl_info` individually.
    This will be slightly less efficient, but this code is generally not called
    in performance-critical paths, and this should be clean, maintainable, and
    platform-independent.
    TV4Fun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b40173e View commit details
    Browse the repository at this point in the history
  4. Fix Android and Web builds

    Neither Android's NDK nor Emscripten provide `backtrace` through `execinfo.h`.
    There are other ways to get a stacktrace on these platforms, but I am not
    expert enough to implement them, so leave them unimplemented for now.
    TV4Fun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0fa4ac1 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fix hashing context example

    Example now works for any file size instead of just multiples of CHUNK_SIZE
    Example also uses correct method for looping over file data
    dmipeck authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    db30f65 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    afa0169 View commit details
    Browse the repository at this point in the history
  3. Update the github Android builds config

    The configuration was updated to generate:
    - Godot Android Editor build
    - Godot Android template build for arm32
    - Godot Android template build for arm64
    
    Co-authored-by: Rémi Verschelde <[email protected]>
    2 people authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    10f467e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48ae4ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    35168f0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    75abfad View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    63a6ec0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    21678c5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7981b4a View commit details
    Browse the repository at this point in the history
  10. Document AudioEffectSpectrumAnalyzerInstance, clarify relationship wi…

    …th AudioEffectSpectrumAnalyzer
    
    Fully document AudioEffectSpectrumAnalyzerInstance, including the weird
    return value of its sole method, and add a link to it in
    AudioEffectSpectrumAnalyzer to make it easier to figure out how to use.
    bpseudopod authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    26b1d32 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7437f4b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    69e4ba6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    573aa0c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f5f322b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c608485 View commit details
    Browse the repository at this point in the history
  16. Remove warning when project setting requests a larger global shader u…

    …niform buffer than the hardware supports.
    
    Instead provide a better error message when the limit is exceeded and avoid crash with a small limit.
    clayjohn authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    aaacafa View commit details
    Browse the repository at this point in the history
  17. ThorVG: Update to 0.14.0

    + Fixes the v0.13.8 svg text error issue.
    + See https://github.com/thorvg/thorvg/releases/tag/v0.14.0
    capnm authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e706d96 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a3ee0bc View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    6cc94d2 View commit details
    Browse the repository at this point in the history
  20. Fix find result current match count

    kitbdev authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3e996cd View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    dda22b0 View commit details
    Browse the repository at this point in the history
  22. Wayland: minimize surface commits and limit them to the main thread

    Before of this patch, as explained in the usual
    commented-wall-of-text-longer-than-the-actual-patch-itself™, due to the
    multithreaded nature of the Wayland thread, it was possible to commit a
    surface while the renderer was doing stuff, which was _very_ wrong.
    
    Initially the consequences of such a sin weren't obvious but, now that
    explicit synchronization is becoming more and more common, we can't
    commit a buffer randomly without basically guaranteeing a nasty, nasty
    crash (and we should have avoided commits altogether in the first place
    to ensure atomic surface updates).
    
    We now only trigger a commit _in the main thread_ when low processor usage
    mode is on _and_ if we know that we won't be rendering anything as, due to
    its intermittent nature, it makes "legacy" (pre xdg_wm_base v6) frame
    callback based suspension quite annoying.
    Riteo authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b6d725a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    10acfc9 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    86f1be8 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    80b1c7a View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    de62c27 View commit details
    Browse the repository at this point in the history
  27. GDScript: partially allow some functions on invalid scripts

    + always default initialize static variables
    + dont invalidate script when dependant scripts don't compile/resolve
    rune-scape authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8de1190 View commit details
    Browse the repository at this point in the history
  28. WorkerThreadPool: Refactor deadlock prevention collaboration into a g…

    …eneric mechanism
    
    This is strictly beyond a refactor because it also changes when the mutexes are relocked,
    but that's only for extra safety.
    RandomShaper authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7bcb187 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    8b9a662 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    c222ee9 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    b00b555 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    32fb747 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    9752b0b View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    f1780fe View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    9af1a9d View commit details
    Browse the repository at this point in the history
  36. Add alternative shortcut for Align Transform to View in the 3D editor

    The new shortcut is Ctrl + Alt + Numpad 0 and is the one listed
    in the 3D viewport's Perspective menu (since PopupMenu accelerators
    display the first shortcut only). This shortcut matches Blender
    and avoids conflicts with the GeForce Experience overlay, which
    defaults to Ctrl + Alt + M.
    
    Ctrl + Alt + M is still defined as an alternative default,
    so that existing workflows are not impacted.
    Calinou authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9ea9161 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    5d9cecc View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    a6cad24 View commit details
    Browse the repository at this point in the history
  39. Update note regarding 3D MSAA and foveated rendering

    godotengine#83976 added support for 3D MSAA on the Compatibility renderer, but it also mentions that on platforms other than Android, foveated rendering will not work if MSAA is enabled.
    
    I removed the note saying that 3D MSAA is not supported on compatibility and added a comment mentioning that foveated rendering won't work on platforms other than android if 3D MSAA is enabled and added the alternative/equivalent for desktop.
    decacis authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9f73e5f View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    d34ea4e View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    9150172 View commit details
    Browse the repository at this point in the history
  42. X11: Fix creating RenderingDevice after godotengine#93706

    The line was removed by mistake.
    akien-mga authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ec7bbd4 View commit details
    Browse the repository at this point in the history
  43. NavigationServer3D.map_get_closest_point_to_segment - add an addition…

    …al shortest distance check
    
    For a case when shortest distance is between some point located on a face's
    edge and some point located on a line segment.
    oshman99 authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    01e3df5 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    c4aeb02 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    ba3f66c View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    d8a84a6 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    e9d945d View commit details
    Browse the repository at this point in the history
  48. Add alternative pixel rounding

    markdibarry authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5f0e6d7 View commit details
    Browse the repository at this point in the history
  49. Fix: set max_width for icons in the quick open popup

    Co-authored-by: Tomek <[email protected]>
    2 people authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8c20c12 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    aad12fb View commit details
    Browse the repository at this point in the history
  51. Fix some TileMapLayer editing problems

    KoBeWi authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7136d1e View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    6fcdfbd View commit details
    Browse the repository at this point in the history
  53. Fix "icon" parameter in EditorPlugin.add_custom_type is not optional,…

    … but docs says it is# This is a combination of 2 commits.
    
    Fix "icon" parameter in EditorPlugin.add_custom_type is not optional, but docs says it is
    
    Update doc/classes/EditorPlugin.xml
    
    Co-authored-by: A Thousand Ships <[email protected]>
    2 people authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8fa0e8e View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    3e03ee2 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    91f70dc View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    fb30b9c View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    cc33f6e View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    5c5fe99 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    6b91aef View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    cd91a78 View commit details
    Browse the repository at this point in the history
  61. Revert "Make freed object different than null in comparison operators"

    This reverts commit 150b50c.
    
    As discussed with the GDScript team, this has some implications which aren't
    fully consensual yet, and which we want to revisit.
    
    For now we revert to the 4.2 behavior for the 4.3 release, to avoid breaking
    user expectations.
    akien-mga authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    eea7c7f View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    e3630fa View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    f15f513 View commit details
    Browse the repository at this point in the history
  64. Fix Info about Global library on add_animation_library method in doc/…

    …classes/AnimationMixer.xml
    
    Fix Info about Global library on add_animation_library method in doc/classes/AnimationMixer.xml
    
    Fix Info about Global library on add_animation_library method
    
    Co-authored-by: Silc Lizard (Tokage) Renew <[email protected]>
    2 people authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    57b7dd6 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    dd88086 View commit details
    Browse the repository at this point in the history
  66. fix animation bezier crash on undo

    CookieBadger authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f61ca88 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    90f7319 View commit details
    Browse the repository at this point in the history
  68. Fix RMB erasing of tiles

    KoBeWi authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3643ea7 View commit details
    Browse the repository at this point in the history
  69. Physics Interpolation - Fix interpolated_transform_2d

    Uses the skew correct `Transform2D::interpolate_with()` function rather than the bugged 3.x version.
    lawnjelly authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    99932ce View commit details
    Browse the repository at this point in the history
  70. Fix: AnimationMixer Example Code

    ayanchavand authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    07c8d9a View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    57c00fd View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    487c81d View commit details
    Browse the repository at this point in the history
  73. [Web] Remove unnecessary EMCC_FORCE_STDLIBS in dlink builds

    As discussed with upstream, the C/C++ standard library is always fully
    included when building with MAIN_MODULE=1, so using EMCC_FORCE_STDLIBS
    is not necessary in our case.
    Faless authored and TV4Fun committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    da8edac View commit details
    Browse the repository at this point in the history