Fix find result current match count issues #93674
Merged
+44
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes match count when searching current and not selecting a match. It should always be the count of the previous one found (or 0 if before all matches).
Found by #93056 (comment)
To reproduce, search for something, move the caret, and use
ctrl+fto search current, then hitenterto search next.Fixes edge case where count being wrong when switching between forward/backwards search and the matches are different. To reproduce, try searching for
ssinsssss.Fixes inconsistent current match count for searching current when caret is unselected inside of a match, based on where it was previously.