[OpenXR] Fix LOCAL_FLOOR emulation on HTC Vive XR Elite
#93678
Merged
+92
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Jun 27, 2024
akien-mga
changed the title
LOCAL_FLOOR emulation on HTC Vive XR Elite
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93647
The main change here, is just that we wait until the next frame to measure the floor height. However, I also took the opportunity to refactor and clean up the
LOCAL_FLOORemulation code a little bit.(Unlike I previously hypothesized, we'd didn't break the
LOCAL_FLOORemulation - it still worked for me on Meta Quest when hard-coding it to use the emulation. The HTC Vive XR Elite just needs to wait a frame, whereas the Quest doesn't.)