Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland: Minimize surface commits and limit them to the main thread #93684

Merged
merged 1 commit into from
Jun 28, 2024

Commits on Jun 27, 2024

  1. Wayland: minimize surface commits and limit them to the main thread

    Before of this patch, as explained in the usual
    commented-wall-of-text-longer-than-the-actual-patch-itself™, due to the
    multithreaded nature of the Wayland thread, it was possible to commit a
    surface while the renderer was doing stuff, which was _very_ wrong.
    
    Initially the consequences of such a sin weren't obvious but, now that
    explicit synchronization is becoming more and more common, we can't
    commit a buffer randomly without basically guaranteeing a nasty, nasty
    crash (and we should have avoided commits altogether in the first place
    to ensure atomic surface updates).
    
    We now only trigger a commit _in the main thread_ when low processor usage
    mode is on _and_ if we know that we won't be rendering anything as, due to
    its intermittent nature, it makes "legacy" (pre xdg_wm_base v6) frame
    callback based suspension quite annoying.
    Riteo committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f27471f View commit details
    Browse the repository at this point in the history