Update note regarding 3D MSAA and foveated rendering #93685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
Jun 28, 2024
Mickeon
approved these changes
Jun 28, 2024
|
@BastiaanOlij can probably verify the information, since he's the author of the PR I mentioned |
|
Almost good, indeed, foveated rendering + MSAA only works on Android (provided certain OpenGL extensions are available, but they will be on all current XR hardware). Otherwise MSAA rendering happens in a separate buffer, and as that isn't provided by OpenXR, foveated rendering is not enabled on that buffer. Also the VRS_MODE alternative only works on Vulkan. |
godotengine#83976 added support for 3D MSAA on the Compatibility renderer, but it also mentions that on platforms other than Android, foveated rendering will not work if MSAA is enabled. I removed the note saying that 3D MSAA is not supported on compatibility and added a comment mentioning that foveated rendering won't work on platforms other than android if 3D MSAA is enabled and added the alternative/equivalent for desktop.
|
I forgot about VRS being Vulkan only! I believe now it should be good, but let me know otherwise. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83976 added support for 3D MSAA on the Compatibility renderer, but it also mentions that on platforms other than Android, foveated rendering will not work if MSAA is enabled.
I removed the note saying that 3D MSAA is not supported on compatibility and added a comment mentioning that foveated rendering won't work on platforms other than android if 3D MSAA is enabled and added the alternative/equivalent for desktop.