Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid [] for external_animation_library import option #95505

Merged

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Aug 14, 2024

Some uses of operator[] were causing "rest_pose/external_animation_library": null to be added to the .import file.

Addresses the user-facing concern of issue #95461 but not the underlying problem that .import file is not meant to be written during an import.

I believe this issue is only cosmetic, and does not need to be rushed in for 4.3

@lyuma lyuma requested a review from a team as a code owner August 14, 2024 00:36
Some uses of operator[] were causing "rest_pose/external_animation_library": null to be added to the .import file.
@lyuma lyuma force-pushed the import_null_external_animation_library branch from 4fef5af to e7de6f8 Compare August 14, 2024 00:54
@akien-mga akien-mga added this to the 4.4 milestone Aug 14, 2024
@akien-mga akien-mga changed the title Avoid [] for external_animation_library import option Avoid [] for external_animation_library import option Aug 14, 2024
@akien-mga akien-mga merged commit 5847d36 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants