Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming nodes on X11 #97447

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Sep 25, 2024

Fixes #97211

This effectively reverts PR #93682 and PR #96829, and takes a completely different approach at fixing issue #88847.

The fix here is much simpler. It looks like the issue with _window_focus_check() in that case was just that we were only checking if the main windows had input focus, but weren't also checking the XIM windows.

I've tested this on:

  • i3 (on both Ubuntu 22.04 and Fedora 40)
  • GNOME (both XOrg and XWayland on Fedora 40)

Testing the following issues / use cases

I'm going to try to get an environment going to test XFCE (for testing issue #74378) and KDE as well. If anyone else has access to another environment help testing would be appreciated!

@dsnopek dsnopek added bug platform:linuxbsd regression cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 25, 2024
@dsnopek dsnopek added this to the 4.4 milestone Sep 25, 2024
@dsnopek dsnopek requested review from a team as code owners September 25, 2024 14:09
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on KDE Plasma on Wayland (running the X11 version of Godot) and it seems to work well :)

@akien-mga akien-mga merged commit f7c567e into godotengine:master Sep 25, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release platform:linuxbsd regression topic:input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming nodes broken on X11
2 participants