Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97211
This effectively reverts PR #93682 and PR #96829, and takes a completely different approach at fixing issue #88847.
The fix here is much simpler. It looks like the issue with
_window_focus_check()
in that case was just that we were only checking if the main windows had input focus, but weren't also checking the XIM windows.I've tested this on:
Testing the following issues / use cases
I'm going to try to get an environment going to test XFCE (for testing issue #74378) and KDE as well. If anyone else has access to another environment help testing would be appreciated!