Automatically assign PBR textures from base texture name in BaseMaterial3D

[Calinou]

This works based on a common set of texture name conventions that most texture sites out there follow. It works with both StandardMaterial3D and ORMMaterial3D. If mismatched textures are detected (compared to the current material type), a notice is displayed.

Since this is implemented in EditorInspectorPluginMaterial, this only affects textures set in the inspector, similar to the existing behavior where roughness and metallic are automatically set to 1.0 when assigning a texture to them.

• This closes Automatically assign PBR textures from base texture name in BaseMaterial3D godot-proposals#11261.

Testing project: test_pbr_autofill.zip

Preview

editor_pbr_autofill.mp4

TODO

• Move the BaseMaterial3D code to a static method, so that we don't need to create an instance of it when assigning textures.
  • This needs Add std::initializer_list constructor for Dictionary. #99751 so the dictionary assignment can be performed statically and moved to the header (since it's read from a static method).
• Implement this for the Decal node as well (could be done in a separate PR).

[lander-vr]

Love this! Does this also work when drag-dropping from the FileSystem?

[fire]

Since this is a hidden feature, can you add some documentation for it in the editor?

[Calinou]

Love this! Does this also work when drag-dropping from the FileSystem?

This currently doesn't apply to either drag-and-dropping onto an object in the 3D viewport, or drag-and-dropping onto a material property in the inspector. It only applies to drag-and-dropping onto a texture property in a material resource in the inspector.

I remember editing the drag-and-drop code at some point, so maybe it should be feasible to implement.

Since this is a hidden feature, can you add some documentation for it in the editor?

Done.

[lander-vr]

It only applies to drag-and-dropping onto a texture property in a material resource in the inspector.

Perfect! That's what I meant! :)

... so maybe it should be feasible to implement.

I assume here you mean drag dropping a single texture onto a meshinstance or material property, and it setting up a StandarMaterial3D/ORM for you with the complete textureset?

If that's the case, I assume it would be a unique material every time? (Seems like a hard problem to solve otherwise)
Considering that, I imagine it would lead to users who are not entirely familiar with this behavior finding themselves in a situation where they've dragged-and-dropped the same texture onto various meshes in a scene, assuming it would apply the same material. I imagine there are performance drawbacks to that, compared to having a single resource that's re-used, but even just considering UX it would probably not be the most intuitive.

[smix8]

Sounds neat but please not as a hidden miracle.

Make this texture auto behavior an Editor setting that can be enabled by default but has the option to be disabled.

Some people get annoyed by the extra clicks of adding textures but I get at least equally annoyed when I have to stare at a frozen Godot due to texture load and add that blocks me from doing anything while firing its selective convenience feature that I dont need. I regularly only want to drag in the albedo texture for a quick model test, not loading all the other textures on purpose because it is so slow. I dont want to rename all those files just to avoid a hidden miracle feature.

[Calinou]

If that's the case, I assume it would be a unique material every time?

Yes, but it's already the case with how the feature works currently.

[Calinou]

Make this texture auto behavior an Editor setting that can be enabled by default but has the option to be disabled.

Done:

[Mickeon]

This note is so much. It would be so INSANELY annoying to read and localize for absolutely everything where this applies. I also am not sure if most of this is necessary, given the setting is enabled by default, and the editor tells you about this action happening. I think the information of what naming standards automatically enable this feature need a better place to exist.

[Geometror]

I agree with @smix8 that this feature shouldn't be a hidden miracle, but disabling it by default hurts discoverability a lot.
What about adding an inspector button (e.g., "Auto-assign PBR textures") right below the material preview that opens a file dialog or directly assigns the textures if one of them was already set? This also has the advantage compared to the current approach that you have more control and can decide whether you need it on a case by case basis.