Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSR_QC.csv #480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update FSR_QC.csv #480

wants to merge 3 commits into from

Conversation

KatarinaRi
Copy link
Contributor

@KatarinaRi KatarinaRi commented Jan 25, 2024

resolves #269

@KatarinaRi KatarinaRi requested a review from ZdenkaB January 25, 2024 10:46
Copy link

Here are the changes in FSR_QC.csv:

1. issue number 1. Person name 1. ORCID 1. FSR long name 1. FSR thing 1. FSR np identifier 1. URI of duplicate(s) (multiple separated by ';') 1. Links correct 1. Proposed Links 1. Definition ok 1. FSR types ok 1. FAIRSharing DOI to be added 1. FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID 1. proposal: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 1. Proposed changes: 2. actual changes: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 2. URI of updated FSR 2. if FSR is useless, check affected FIPs or SIPs (title) 2. Updated (U) /Deleted (D) entry in FIP/SIP
- 447 Parul Tewatia 0000-0002-3096-1318 The PRIDE PRoteomics IDEntifications (PRIDE) https://w3id.org/np/RAs7jaVVbupfUR5U55BnhCkj9McJ30M8GQcaYtkF7AJZA#PRIDE https://w3id.org/np/RAs7jaVVbupfUR5U55BnhCkj9McJ30M8GQcaYtkF7AJZA https://w3id.org/np/RAs7jaVVbupfUR5U55BnhCkj9McJ30M8GQcaYtkF7AJZA Y Y Y F A
+ 269 Katarina Rihackova 0000-0003-0222-801x Climate Model Intercomparison Project phase 6 controlled vocabulary http://purl.org/np/RAyiELhxiz4Sw7qa8QLcfSOcwHSD9PuHb1szHsULrhDaQ#CMIP6 http://purl.org/np/RAyiELhxiz4Sw7qa8QLcfSOcwHSD9PuHb1szHsULrhDaQ N https://github.com/WCRP-CMIP/CMIP6_CVs N N F I Provide definition; clarify FSR type; change link if the FSR is reffering to the vocabulary; not found in FAIRsharing;
+ 447 Parul Tewatia 0000-0002-3096-1318 The PRIDE PRoteomics IDEntifications (PRIDE) https://w3id.org/np/RAs7jaVVbupfUR5U55BnhCkj9McJ30M8GQcaYtkF7AJZA#PRIDE https://w3id.org/np/RAs7jaVVbupfUR5U55BnhCkj9McJ30M8GQcaYtkF7AJZA https://w3id.org/np/RAs7jaVVbupfUR5U55BnhCkj9McJ30M8GQcaYtkF7AJZA Y Y Y F A

Copy link
Contributor

@ZdenkaB ZdenkaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Katarína, I would suggest discussing these changes with Barbara or directly with the author. There are additional FIPs related to the CMIP6 project, and it seems quite complicated to me. Furthermore, there have been some changes to these FIPs made in the last few minutes/hours, so it would probably be a good idea to review them before you start making any changes

@mabablue mabablue requested a review from rbramley March 29, 2024 06:58
@mabablue
Copy link
Contributor

dear @rbramley can you help closing this issue please?

Copy link

github-actions bot commented Apr 8, 2024

Here are the changes in FSR_QC.csv:

1. issue number 1. Person name 1. ORCID 1. FSR long name 1. FSR thing 1. FSR np identifier 1. URI of duplicate(s) (multiple separated by ';') 1. Links correct 1. Proposed Links 1. Definition ok 1. FSR types ok 1. FAIRSharing DOI to be added 1. FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID 1. proposal: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 1. Proposed changes: 2. actual changes: accept (A) / Improve (I) / Retract (R) / Disapprove (D) 2. URI of updated FSR 2. if FSR is useless, check affected FIPs or SIPs (title) 2. Updated (U) /Deleted (D) entry in FIP/SIP
+ 269 Katarina Rihackova 0000-0003-0222-801x Climate Model Intercomparison Project phase 6 controlled vocabulary http://purl.org/np/RAyiELhxiz4Sw7qa8QLcfSOcwHSD9PuHb1szHsULrhDaQ#CMIP6 http://purl.org/np/RAyiELhxiz4Sw7qa8QLcfSOcwHSD9PuHb1szHsULrhDaQ N https://github.com/WCRP-CMIP/CMIP6_CVs N N F I Provide definition; clarify FSR type; change link if the FSR is reffering to the vocabulary; not found in FAIRsharing;

@rbramley
Copy link
Contributor

rbramley commented Apr 9, 2024

@mabablue The improvement hasn't been actioned, also there seems to be a potential duplicate: http://purl.org/np/RAuUzmorfO0tJGzmqaQpaas5BkACS3loFju52-R9_ga-w

Would you like me to complete the improvement, qualification and then merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Climate Model Intercomparison Project phase 6 controlled vocabulary
4 participants