chore: update dependencies #1382
Conversation
ReneWerner87
requested review from
efectn,
gaby and
sixcolors
and removed request for
a team
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ReneWerner87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating Go module dependencies across various middleware and integration packages. The most significant update is the migration to github.com/gofiber/fiber/v3 v3.0.0-rc.1, which necessitated adjustments in several modules to align with the new Fiber API and behavior. Beyond dependency bumps, specific functional improvements include better New Relic transaction context management, a new default context key for PASETO, and test updates to reflect Fiber v3's changes in response headers and logging details. These changes ensure compatibility and leverage the latest features and fixes from updated libraries.
Highlights
- Core Fiber v3 Release Candidate Update: The core Fiber framework dependency has been updated across all modules from a beta version to the release candidate (RC.1), indicating a move towards a stable Fiber v3 release. This update impacts all middleware and integrations.
- Testify Library Upgrade: The
stretchr/testifytesting library has been upgraded tov1.11.0across most modules, which may include new assertion methods or bug fixes for tests. - New Relic Transaction Context Handling Improvement: The
fibernewrelicmiddleware now explicitly stores the New Relic transaction in the Fiber context'sLocalsmap, and theFromContexthelper function has been updated to retrieve it from there. This change adapts to Fiber v3's context handling and removes a previous TODO item. - Fiber v3 Test Behavior Alignment: Tests in
fiberzapandfiberzerologhave been updated to reflect changes in Fiber v3's default behavior, such as the 'protocol' string ('HTTP/1.1' instead of 'http') and default 'resBody' for 404 responses ('Not Found' instead of 'Cannot GET /'). This ensures test accuracy with the new Fiber version. - PASETO Configuration Enhancement: The
pasetomiddleware's default configuration now includes aContextKey, improving configurability and consistency for PASETO token handling. - Content-Type Header Standardization in Tests: Several modules, including
circuitbreakerandloadshed, have updated their test assertions forContent-Typeheaders to explicitly includecharset=utf-8, reflecting a more precise and common standard for JSON responses. - FGProf Timeout Configuration Fix: The
fgprofmiddleware's tests now correctly usetime.Millisecondfor timeout configurations, ensuring proper handling of time-based settings with Fiber v3.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request primarily updates dependencies across various modules, most notably upgrading to github.com/gofiber/fiber/v3 v3.0.0-rc.1. The changes include necessary adjustments to tests and middleware to align with the new Fiber v3 API, such as changes to Timeout configuration and Next function signatures. Additionally, the New Relic middleware has been updated to store the transaction on the request context, and the Paseto middleware now includes a default context key. The changes are well-contained and seem correct. I have one suggestion to improve maintainability by replacing a magic string with a constant.
| defer txn.End() | ||
|
|
||
| // Store transaction for retrieval via FromContext | ||
| c.Locals("newrelic_txn", txn) |
There was a problem hiding this comment.
The string literal "newrelic_txn" is used as a key for c.Locals here and in the FromContext function. To improve maintainability and avoid magic strings, it would be better to define this as a constant at the package level. For example: const newrelicTxnKey = "newrelic_txn".
Summary
Testing
go test ./...(circuitbreaker)go test ./...(fgprof)go test ./...(fiberzap)go test ./...(fiberzerolog)go test ./...(fibernewrelic)go test ./...(monitor)go test ./...(loadshed)go test ./...(paseto)golangci-lint run --tests=false --timeout=5m(fails: Go version mismatch)https://chatgpt.com/codex/tasks/task_e_68ad8f253edc83268d9433c7034a0eea