-
Notifications
You must be signed in to change notification settings - Fork 153
chore: bump module paths for v3 #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module github.com/gofiber/contrib/casbin | ||
| module github.com/gofiber/contrib/v3/casbin/v1 | ||
|
|
||
| go 1.25.0 | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ func Test_Fgprof_Path(t *testing.T) { | |
| app.Use(New()) | ||
|
|
||
| // Default fgprof interval is 30 seconds | ||
| resp, err := app.Test(httptest.NewRequest("GET", "/debug/fgprof?seconds=1", nil), fiber.TestConfig{Timeout: 1500}) | ||
| resp, err := app.Test(httptest.NewRequest("GET", "/debug/fgprof?seconds=0", nil)) | ||
| assert.Equal(t, nil, err) | ||
|
Comment on lines
54
to
58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P1] Restore fgprof test duration to avoid timeouts Changing Useful? React with 👍 / 👎. |
||
| assert.Equal(t, 200, resp.StatusCode) | ||
|
Comment on lines
56
to
59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix 400 and timeout: seconds=0 is invalid; also pass a time.Duration timeout
import (
"io"
"net/http/httptest"
"testing"
"github.com/stretchr/testify/assert"
"github.com/gofiber/fiber/v3"
+ "time"
)
@@
// Default fgprof interval is 30 seconds
- resp, err := app.Test(httptest.NewRequest("GET", "/debug/fgprof?seconds=0", nil))
+ resp, err := app.Test(
+ httptest.NewRequest("GET", "/debug/fgprof?seconds=1", nil),
+ fiber.TestConfig{Timeout: 2 * time.Second},
+ )
assert.Equal(t, nil, err)
assert.Equal(t, 200, resp.StatusCode)Also applies to: 3-11 🧰 Tools🪛 GitHub Actions: Test Fgprof[error] 59-59: go test -v -race ./...: Test_Fgprof_Path failed: Not equal: expected 200, actual 400. 🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module github.com/gofiber/contrib/fgprof | ||
| module github.com/gofiber/contrib/v3/fgprof/v1 | ||
|
|
||
| go 1.25.0 | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module github.com/gofiber/contrib/fiberi18n/v2 | ||
| module github.com/gofiber/contrib/v3/fiberi18n/v1 | ||
|
|
||
| go 1.25.0 | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config callback types should return error
Examples below use
func(fiber.Ctx) error; align the table to avoid confusion.📝 Committable suggestion
🤖 Prompt for AI Agents