-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix/gofr telemetry #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Fix/gofr telemetry #2348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks okay. But we need to also set-up the other side of the telemetry processing that is the endpoint : "https://gofr.dev/telemetry/v1/metrics". Can we add the approach details of how will it work on the other side in the PR description. Add the link to the corresponsing setup PR on the website side(I am supposing here).
Pull Request Template
Description:
GOFR_TELEMETRY_DISABLED
environment variable.Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!