Adds getPortProperties for Windows #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also made a few changes so that MS compiler would be able to compile
Compiled in MSVC 2017. Needs to add setupapi.lib for linker & give path to JDK includes.
Tested on Win & Linux
|
@RomanBelkov Thank you for this contribution! I am a bit busy with other things, but I will definitely have a close look soon. |
It appeared, that if you change device description (CP2102 in my case), you'll still get default description given by Windows where the new, changed device description is expected. Luckily, in Windows 7 and above there is a way to do so. Note that this commit will probably break everything on XP & Vista.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the main library does not accept pull requests and presumably cold dead, I pull request here, so the complete getPortProperties will be available more than in one repo.
I also request a code review, because my C++ skills are pretty bad.