-
Notifications
You must be signed in to change notification settings - Fork 89
used goreleaser to create binaries and SBOM ,attached it to caintainer #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=========================================
- Coverage 10.99% 7.55% -3.44%
=========================================
Files 173 226 +53
Lines 8671 13666 +4995
=========================================
+ Hits 953 1033 +80
- Misses 7612 12527 +4915
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The vulnerability check was previously failing due to known security issues in Go standard libraries, as seen in the pre-update report by running Updated Go to version 1.24.4, which resolves the reported vulnerabilities. Also upgraded Dagger to version 0.18.10 for compatibility. After the updates, re-running the check shows no remaining vulnerabilities, as confirmed in the post-update report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions
Please fix the suggestions
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: hippie-danish <[email protected]>
Signed-off-by: danish9039 <[email protected]>
Hi @bupd , sorry for the delay , looks like i should increase the code coverage for |
Signed-off-by: danish9039 <[email protected]>
@bupd , can you check this , looks like a lot of files needs their code coverage to be improved ? |
so the best way would be to use goreleaser to create binaries and put those binaries in respective container images using dagger and push to registry and so you can also attach the sbom created by the goreleaser to the container. since the container is from scratch and has only harbor-cli binary. |
Please do join the next harbor-cli community meeting so we can discuss this and plan. Thanks for your contributions |
Related Issues
Fixes
Description
This PR enhances the CI/CD pipeline by using GoReleaser to build binaries and SBOM and use it in Dagger containers .
Key Changes
Dagger Improvements
publishImage
function in.dagger/main.go
)./usr/share/doc/harbor/
.GitHub Workflow
New Behavior
On tag push:
On main branch push:
Testing
dagger call publish-image
main
branch