-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support existing secret for external DB #1783
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandre DEFRASNE <[email protected]>
Signed-off-by: Alexandre DEFRASNE <[email protected]>
Signed-off-by: Alexandre DEFRASNE <[email protected]>
Signed-off-by: Alexandre DEFRASNE <[email protected]>
Signed-off-by: Alexandre DEFRASNE <[email protected]>
Signed-off-by: Alexandre DEFRASNE <[email protected]>
Hi @cest-pas-faux , I don't think these settings expect Best, |
Hi @MinerYang, thanks for this review The
I didn't want to create a breaking change by removing this secret which is shared by different components. |
Hi @MinerYang , any updates on this ? |
Hi,
This PR adds the ability to specify an existing secret for all the DB configurations (host, port, user, password, coreDatabase).
Tests done with this updated chart :
existingSecret.enabled: true
external
and setexistingSecret.enabled: false
Both tests are successful, pull/push images OK.