Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor YAML to Use Template Values for Security Context #1818

Closed
wants to merge 4 commits into from

Conversation

Nithinrao9696
Copy link

Summary

This PR updates the YAML configuration to replace hardcoded values for runAsUser and fsGroup with templated values. This change enhances the configurability and maintainability of the configuration files.

Details

  • Updated Security Context:
    • Replaced hardcoded runAsUser value with {{ .Values.database.securityContext.runAsUser }}
    • Replaced hardcoded fsGroup value with {{ .Values.database.securityContext.fsGroup }}

These changes allow for more flexible configuration management by enabling the values to be defined dynamically based on the values provided in the Helm chart's values file.

Impact

  • Configuration Flexibility: This update improves the flexibility of configuration management, allowing different values to be easily set through the Helm values file.
  • Maintainability: Centralizing configuration values in the Helm values file makes future updates easier and reduces the risk of errors associated with hardcoding values.

How to Test

  1. Ensure that the Helm values file (values.yaml or equivalent) contains the necessary runAsUser and fsGroup values under the database.securityContext section.
  2. Deploy or render the Helm chart to verify that the YAML configuration reflects the templated values as expected.

Additional Notes

  • No functional changes are expected; this is a refactoring change.
  • Reviewers should verify that the templated values are correctly applied during deployment.

Please review the changes and provide feedback.

@Vad1mo
Copy link
Member

Vad1mo commented Aug 28, 2024

@Nithinrao9696 DCO is still missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants