Skip to content

Fix handling of missing replies in comments #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soodoku merged 1 commit into from
Jul 9, 2025
Merged

Fix handling of missing replies in comments #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions R/get_all_comments.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ process_page <- function(res = NULL) {

if (!is.null(comment$replies) && "comments" %in% names(comment$replies)) {
reply_items <- comment$replies$comments

if (!is.null(reply_items) && length(reply_items) > 0) {
n_replies <- if (is.null(reply_items)) 0 else length(reply_items)

if (n_replies > 0) {
reply_data <- lapply(reply_items, function(reply) {
reply_snippet <- reply$snippet
reply_id <- reply$id
Expand Down
30 changes: 30 additions & 0 deletions tests/testthat/test-get-all-comments.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
context("Get All Comments")

test_that("process_page handles comments with and without replies", {
# Construct sample API response
res <- list(
items = list(
list(
id = "c1",
snippet = list(topLevelComment = list(snippet = list(textDisplay = "t1"))),
replies = list(comments = list(
list(id = "c1r1", snippet = list(textDisplay = "r1")),
list(id = "c1r2", snippet = list(textDisplay = "r2"))
))
),
list(
id = "c2",
snippet = list(topLevelComment = list(snippet = list(textDisplay = "t2")))
# No replies
)
)
)

df <- tuber:::process_page(res)

expect_s3_class(df, "data.frame")
expect_true(any(is.na(df$parentId))) # top level comments
expect_true(any(!is.na(df$parentId))) # replies present
expect_true("c2" %in% df$id) # second comment present
expect_false(any(df$parentId == "c2")) # no replies for c2
})
Loading