update build instructions #141
Conversation
README.md
Outdated
| Dependencies: you only need `docker` and `bash` installed on your machine. | ||
| #### To build composer | ||
|
|
||
| environmental variable ANDROID_HOME must be set. |
There was a problem hiding this comment.
Capital E, wrap ANDROID_HOME with ` :)
There was a problem hiding this comment.
And afaik it's called environment variable, not environmental hehe
README.md
Outdated
| npm build | ||
| ``` | ||
|
|
||
| #### All-in-one script (used in Travis build) |
There was a problem hiding this comment.
Can we put this one at the top of "How to build"? I don't want people install npm and stuff to build Composer
README.md
Outdated
| ./gradlew build | ||
| ``` | ||
|
|
||
| #### To build html-report |
There was a problem hiding this comment.
"Build HTML report module"?
README.md
Outdated
| @@ -161,7 +161,27 @@ Composer works great in combination with [Swarmer][swarmer] — another tool we' | |||
|
|
|||
| ### How to build | |||
|
|
|||
| Dependencies: you only need `docker` and `bash` installed on your machine. | |||
| #### To build composer | |||
README.md
Outdated
|
|
||
| #### All-in-one script (used in Travis build) | ||
|
|
||
| you only need `docker` and `bash` installed on your machine. |
There was a problem hiding this comment.
Dependencies: docker and bash.
README.md
Outdated
|
|
||
| #### To build html-report | ||
|
|
||
| you need `npm` and `nodejs` packages installed. |
There was a problem hiding this comment.
Dependencies: npm and nodejs.
| @@ -3,7 +3,7 @@ ext.versions = [ | |||
|
|
|||
| rxJava : '1.3.0', | |||
| jCommander : '1.71', | |||
| commander : '0.1.6', | |||
| commander : '0.1.7', | |||
There was a problem hiding this comment.
why in this pr tho? pls extract to separate one
There was a problem hiding this comment.
because it addresses the same thing: informative message on ANDROID_HOME error while running build, and no more
#134 suggestion, also sent a PR to gojuno/commander#15 for meaningful message about missing ANDROID_HOME